drenther / upi_pay

Flutter plugin for UPI (Only in India)
MIT License
60 stars 71 forks source link

update your upi_pay dependency please #44

Open salonishrivastava opened 3 years ago

salonishrivastava commented 3 years ago

update your upi_pay dependency please. it is showing android embidded issue v2 depreceted after i update android studio flutter plugin you can see audio_service plugin that is working with new update

vivekn4u commented 3 years ago

We are getting this message, should we need to be worried about this?

The plugin upi_pay uses a deprecated version of the Android embedding. To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration

reeteshranjan commented 3 years ago

Please report if you see runtime failures as mentioned in Flutter build message. I am yet to see any.

Having said that, the work on fixing this is ongoing. There was a similar issue earlier for which I had recreated the android platform code of the plugin, which creates the manifest, java/kotlin flutter channel/plugin support code using Flutter's recommended structure to not have the embedding related issues reported by build. I am currently working on the fresh new build warning around embedding that is covered in this bug with a similar approach.

reeteshranjan commented 3 years ago

For people watching this bug: I got stuck and have asked @drenther to look at and help. If anyone else can help with debugging and fixing the Kotlin code, please let us know. All help is welcome.

PS-Developers commented 2 years ago

Kindly resove issue

The plugin upi_pay uses a deprecated version of the Android embedding. To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs. If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

drenther commented 2 years ago

Unable to prioritise this at the moment. Happy to take a PR for this.

drenther commented 2 years ago

Make a PR please if you already have solution.

reeteshranjan commented 2 years ago

@SelvamDev I can see that your solution uses PluginRegistry, which I believe is part of the deprecated embedding style. Have you checked that the embedding related warning goes away with your version?

In case the embedding warning has gone away, it's great. Otherwise, could you please check this version https://github.com/reeteshranjan/upi_pay/tree/embedding-fix? If I remember correctly, I had to remove the PluginRegistry to get the embedding related warning to go away. This is also the case in this recent embedding fix in another example package https://github.com/g123k/flutter_app_badger/pull/47/files. I was working on fixing the embedding issue and could not resolve the issue of not getting a response back from the intent call and did not have time to follow up and complete the work. This branch mentioned above has the latest that I could get to.

Please also paste the output of flutter doctor -v in your dev setup.

joshuajennysibbu commented 2 years ago

Hai @reeteshranjan I am waiting for your update. This repo still return warning. I am using flutter 2.5.3. Please fix this issue as soon as possible.

reeteshranjan commented 2 years ago

@joshuajennysibbu have been not able to find time. A PR is welcome.

reeteshranjan commented 2 years ago

Is this https://github.com/drenther/upi_pay/issues/38 relevant and important for you?

If yes, could you please respond to my twitter thread with UPI and NPCI handles included in your response asking how these must be solved and how it helps you? https://twitter.com/reeteshr08/status/1488746633068089345

@vivekn4u @salonishrivastava @joshuajennysibbu

drenther commented 2 years ago

If this issue concerns you still. Please have a look at #62 by @GJJ2019 and leave your comments on that PR. Will have merge that PR and close this issue ASAP.