search

dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices
BSD 3-Clause "New" or "Revised" License
1.9k stars 498 forks source link

Add `config/setvalve` item to generic #7614

Open mattreim opened 7 months ago

mattreim commented 7 months ago

valve_set

mattreim commented 7 months ago

The name "valve_set" fits better to "windowopen_set".

mattreim commented 7 months ago

With setvalve I somehow expect this object.

Setvalve

manup commented 7 months ago

While the original name doesn't have the ideal consistency this PR would be a breaking change for little gain (I think).

There are a few existing legacy devices out there which were joined with the config/setvalve item.

image

Further it changes the API for clients which would need to support with old vs. new deCONZ version. To be honest I wouldn't do that.

If such a change is to be made it should deprecate the old item name while adding a new one and support both for some time until the old one is removed.

mattreim commented 7 months ago

If the effort is too high, I can of course change it back to "setvalue". But it would still be good to use it again in DDF`s.

mattreim commented 7 months ago

I've changed it again now.