Fix consumption reporting for Lidl SilverCrest (_TZ3000_j1v25l17)

dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices

BSD 3-Clause "New" or "Revised" License

1.9k stars 498 forks source link

Fix consumption reporting for Lidl SilverCrest (_TZ3000_j1v25l17) #7621

Closed Fischelsberger closed 7 months ago

Fischelsberger commented 7 months ago

I've create a PR for this issue, @FlatTV provided the fix in #7603.

I've used a little bit different approach, because the missing ";" seemed as an issue compare to a different DDF of a Tuya Device. Seems like the ";" was missing and also the "Item" was written Lowercase.

resolves #7603

old:

"eval": "item.val = 10 * Attr.val"

new:

"eval": "Item.val = Attr.val * 10;"

FlatTV commented 7 months ago

I think the lowercase of „Item.val“ is the only problem here

manup commented 7 months ago

The former 420 interval is also better since it needs to be higher than the respective reporting interval.

Fischelsberger commented 7 months ago

sorry, I think I screwed up my commit now... Wanted to change the 300 back to 420, and guess that not worked out...

Not used to the usage of git in general...

But it seems fine now (with 2 additional commits...)?

manup commented 7 months ago

Multiple commit are fine, we mostly do squash merge the PRs so they get reduced to one commit :)