dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices
BSD 3-Clause "New" or "Revised" License
1.9k stars 498 forks source link

Add cooling mode to Bosch room thermostat II (BTH-RM) #7681

Open mattreim opened 6 months ago

mattreim commented 6 months ago

image

manup commented 5 months ago

Tricky, I don't have any experience with that device, but it looks like the PR introduces a breaking change due the renamed values? Is the removal of "auto" and "heat" really needed or is it better to only extend the existing modes with the new ones?

mattreim commented 5 months ago

ioBroker_room_thermostat

I think renaming "auto" is not necessary, but heat in manual is more understandable here. Incorrect operation could occur if "heat" is used twice.

operation manual:

operation_manual

mattreim commented 5 months ago

The modes auto, manual and off are functional in both channels cool and heat.

mattreim commented 5 months ago

Unfortunately, when you turn off the device, the following error message appears:

Room_thermostat_error_message

And this under cluster info:

Room_thermostat_off_temp

SwoopX commented 5 months ago

I'm sorry, but I cannot say that the recent changes can get my vote. My perception is that thing got even more complicated and drift away from common user experience. Is there any particular reason why you chose to ignore the requested changes?

If I haven't overlooked anything, the amendments you've made over time state that all the required mode changes can be done through attribute 0x001C, being the zigbee intended way. That makes we wonder why not to use it?

mattreim commented 5 months ago

Sorry, maybe I didn't make myself clear. Here are the device attributes:

0x001C:

0x001C

0x4007:

0x4007

mattreim commented 5 months ago

The different states:

(Mode --> devicemodes)

heat --> manual, auto and off

cool --> manual, auto and off

off --> off

mattreim commented 5 months ago

They're just names and it works like that.

mattreim commented 5 months ago

Inspired by Home Assistant;

Home_Assistant

github-actions[bot] commented 3 weeks ago

Hey @mattreim, thanks for your pull request!

[!TIP] Modified bundles can be downloaded here. Relative expire date

DDB changes

Modified

Validation

[!TIP] Everything is fine !

:clock1130: Updated for commit 6057f677ce617c894f2110086acb3d075f13ec46