Open mattreim opened 6 months ago
Tricky, I don't have any experience with that device, but it looks like the PR introduces a breaking change due the renamed values? Is the removal of "auto" and "heat" really needed or is it better to only extend the existing modes with the new ones?
I think renaming "auto" is not necessary, but heat in manual is more understandable here. Incorrect operation could occur if "heat" is used twice.
operation manual:
The modes auto, manual and off are functional in both channels cool and heat.
Unfortunately, when you turn off the device, the following error message appears:
And this under cluster info:
I'm sorry, but I cannot say that the recent changes can get my vote. My perception is that thing got even more complicated and drift away from common user experience. Is there any particular reason why you chose to ignore the requested changes?
If I haven't overlooked anything, the amendments you've made over time state that all the required mode changes can be done through attribute 0x001C, being the zigbee intended way. That makes we wonder why not to use it?
Sorry, maybe I didn't make myself clear. Here are the device attributes:
0x001C:
0x4007:
The different states:
(Mode --> devicemodes)
heat --> manual, auto and off
cool --> manual, auto and off
off --> off
They're just names and it works like that.
Inspired by Home Assistant;
Hey @mattreim, thanks for your pull request!
[!TIP] Modified bundles can be downloaded here.
bosch/room_thermostat2.json
: Room thermostat II (BTH-RM) :heavy_check_mark:[!TIP] Everything is fine !
:clock1130: Updated for commit 6057f677ce617c894f2110086acb3d075f13ec46