dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices
BSD 3-Clause "New" or "Revised" License
1.9k stars 498 forks source link

DDF for Bosch Light/shutter control II #7683

Closed SwoopX closed 5 months ago

SwoopX commented 6 months ago

Interesting device. Making an educated guess here, especially on the switch resource and the button map. Would be great if it could be tested upfront.

Closes #7661

Smanar commented 6 months ago

Hello, you are sure for

        <attribute id="0x0000" name="Device mode" type="enum8" mfcode="0x1209" access="rw" required="m"></attribute>
        <attribute id="0x0001" name="Switch type" type="enum8" mfcode="0x1209" access="rw" required="m"></attribute>

According that I have see on the link gived by the user, the attribute 0x0000 is the device mode yes, but for me it's more something like

        <attribute id="0x0000" type="enum8" name="Device mode" access="rw" required="o" mfcode="0x1209">
             <value name="undefined" value="0x00"></value>
            <value name="shutter" value="0x01"></value>
            <value name="light" value="0x04"></value>
        </attribute>

From https://github.com/zigpy/zha-device-handlers/issues/2518#issuecomment-1778844145

Edit:

        <attribute id="0x0001" type="enum8" name="Switch type" access="rw" required="o" mfcode="0x1209">
            <value name="undefined" value="0x00"></value>
            <value name="button" value="0x01"></value>
            <value name="key change" value="0x02"></value>
            <value name="switch" value="0x03"></value>
            <value name="switch key change" value="0x04"></value>
        </attribute>
SwoopX commented 6 months ago

@Smanar ah, forgot the values. Thanks for poking me, will add them later 👍🏻

manup commented 5 months ago

Ready to merge? :)

SwoopX commented 5 months ago

Ready to merge? :)

I'd say so 🙂