Removal of legacy code for various devices

dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices

BSD 3-Clause "New" or "Revised" License

1.9k stars 503 forks source link

Removal of legacy code for various devices #7822

Closed SwoopX closed 3 months ago

SwoopX commented 4 months ago

Devices are meanwhile covered by DDFs:

Wiser iTRV thermostat
Ikea Styrbar remote
Ikea Kadrilj blind
Sinope TH1123ZB/TH1124ZB thermostats

github-actions[bot] commented 4 months ago

Hey @SwoopX, thanks for your pull request!

[!TIP] Modified bundles can be downloaded here.

DDB changes

Modified

sinope/th1124zb.json : Smart thermostat for electric heating (TH1123ZB/TH1124ZB) :heavy_check_mark:

Validation

[!TIP] Everything is fine !

_{:clock5: Updated for commit 7bc41e92c611c31abc239b56a35f1e96e711757e}

manup commented 4 months ago

Thanks, always nice to see the C++ monsters shrinking :)

I'd suggest we merge this in the first v2.28.0-beta since this is mostly a cleanup.

For the "Sinope TH1123ZB/TH1124ZB thermostats" when I read it right this brings the TH1123ZB from legacy code into the DDF with a few enhancements. Here I'd prefer to have this bit as separate PR.

SwoopX commented 4 months ago

Yeah, still a long way to go to get the old stuff out

For the "Sinope TH1123ZB/TH1124ZB thermostats" when I read it right this brings the TH1123ZB from legacy code into the DDF with a few enhancements. Here I'd prefer to have this bit as separate PR.

I guess this looks more serious than it actually is. If memory serves, the 2 devices are identical except for the load they can manage. In that sense, just added the 1123 to the DDF, added the bindings on the thermostat cluster that were missing (incl. refresh amendments) and corrected the non-functioning state/on.

However, if you still prefer a seperate PR for it, I can set one up.

manup commented 4 months ago

Ah ok thanks, keeping it as one PR here is fine by me. Added to v2.28.0-beta milestone.

manup commented 3 months ago

Also needs a small update to make GIT happy :)

SwoopX commented 3 months ago

Then let Git be happy 🙂

github-actions[bot] commented 3 months ago

This pull request is now merged. The new DDB files have been uploaded to the store.

DDB Files

Modified

sinope/th1124zb.json : Smart thermostat for electric heating (TH1123ZB/TH1124ZB) : with hash (649b4fa640)

_{:clock8: Updated for commit e97d5beb4d4f41ee1b7e89b08cfae782750ccc8c}