dresden-elektronik / deconz-rest-plugin

deCONZ REST-API plugin to control ZigBee devices
BSD 3-Clause "New" or "Revised" License
1.9k stars 503 forks source link

Update hs1sa_smoke_sensor.json #7858

Closed MSL-DA closed 3 months ago

github-actions[bot] commented 3 months ago

Hey @MSL-DA, thanks for your pull request!

[!TIP] Modified bundles can be downloaded here. Relative expire date

DDB changes

Modified

Validation

[!TIP] Everything is fine !

:clock4: Updated for commit 5f672f4b9d63cf3a40ba7d6cfbd7095a96f91869

Smanar commented 3 months ago

Hello, To make a DDF compatible with 2 devices need to use

  "manufacturername": ["MFN  1", "MFN 2"],
  "modelid": ["Model id1","Model id2"],
  "vendor": "HEIMAN",

manufacturername and modelid need to be exactly the same than you can see in the GUI

Smanar commented 3 months ago

Same problem ^^, this can't work

  "manufacturername": "HEIMAN, Heiman",
  "modelid": "SmokeSensor-EF-3.0, SmokeSensor-EF-3.0",

There is 2 devices ? One with "HEIMAN" and another with "Heiman" ?

MSL-DA commented 3 months ago

Same problem ^^, this can't work

  "manufacturername": "HEIMAN, Heiman",
  "modelid": "SmokeSensor-EF-3.0, SmokeSensor-EF-3.0",

There is 2 devices ? One with "HEIMAN" and another with "Heiman" ?

Yes ... if I specify Heiman in my DDF, it is not selected. I have to write HEIMAN

MSL-DA commented 3 months ago

Is this correct?

  "manufacturername": "HEIMAN, Heiman",
  "modelid": "SmokeSensor-EF-3.0",
  "vendor": "HEIMAN",
  "product": "HS1SA"
Smanar commented 3 months ago

So it mean, if you look on deconz the device Manufacture name is HEIMAN, Heiman ?

Smanar commented 3 months ago
    "manufacturername": [
    "HEIMAN",
    "Heiman"
  ],
  "modelid": [
    "SmokeSensor-EF-3.0",
    "SmokeSensor-EF-3.0"
  ],

This is fine, it mean you can have a device with Heiman/SmokeSensor-EF-3.0 and another with HEIMAN/SmokeSensor-EF-3.0

Smanar commented 3 months ago

@MSL-DA why have you cancelled your PR ? The last one was fine.