Open ebaauw opened 3 weeks ago
Not sure why the validation checks fail. These changes pass ddf-tool validate
locally:
$ ddf-tools validate -d devices
- Using validator version 2.31.1
✔ Found 662 files to validate
Skipping file devices/danalock/danalock_v3.json because it has the ddfvalidate option set to false
Skipping file devices/legrand/cable_outlet.json because it has the ddfvalidate option set to false
✔ Loaded 270 generic files and 390 DDF files from disk
✔ No errors found in 270 generic files
✔ No errors found in 390 ddf files
For posterity: that was caused by an item JSON filename not ending in ..._item.json
.
Hey @ebaauw, thanks for your pull request!
[!TIP] Modified bundles can be downloaded here.
icasa/ICZB-IW21SW.json
: Zigbee On/Off Switch PRO :heavy_check_mark:
philips/soc001_contact_sensor.json
: Hue secure contact sensor :heavy_check_mark:
philips/rom001_smart_button.json
: Hue smart button :heavy_check_mark:
philips/rdm001_wall_switch_module.json
: Hue wall switch module :heavy_check_mark:
philips/rwl022_dimmer_switch.json
: Hue dimmer switch (2021) :heavy_check_mark:
philips/rwl02_dimmer_switch.json
: Hue dimmer switch :heavy_check_mark:
dresden_elektronik/kobold.json
: Smart dimmer switch (Kobold) :heavy_check_mark:
philips/lom007_smart_plug.json
: Hue smart plug :heavy_check_mark:
icasa/ICZB-IW11D.json
: AC dimmer (ICZB-IW11D) :heavy_check_mark:
innr/sp_240.json
: Smart plug (SP 240) :heavy_check_mark:
philips/rdm002_tap_dial_switch.json
: Hue tap dial switch :heavy_check_mark:
ikea/tradfri_driver_30w.json
: Tradfri LED Driver for Wireless Control 30W (ICPSHC24-10EU-IL-1/ICPSHC24-10NA-IL-1) :heavy_check_mark:
fireangel/generic_alarm.json
: Zigbee Radio Module (P-LINE) :heavy_check_mark:
fireangel/smoke_alarm.json
: Zigbee Radio Module (P-LINE) :heavy_check_mark:
fireangel/co_alarm.json
: Zigbee Radio Module (P-LINE) :heavy_check_mark:
philips/light_zb3_white.json
: Hue white light :heavy_check_mark:
icasa/ICZB-IW21D.json
: Zigbee Dimmer PRO :heavy_check_mark:
philips/light_zll_white_ambiance.json
: Hue white ambiance light :heavy_check_mark:
philips/light_zb3_white_ambiance.json
: Hue white ambiance light :heavy_check_mark:
philips/light_zll_A.json
: Hue color ambiance light :heavy_check_mark:
philips/sml001_motion_sensor.json
: Hue motion sensor :heavy_check_mark:
philips/sml003_motion_sensor.json
: Hue motion sensor (2022) :heavy_check_mark:
philips/sml004_motion_sensor.json
: Hue outdoor motion sensor (2022) :heavy_check_mark:
philips/sml002_motion_sensor.json
: Hue outdoor motion sensor :heavy_check_mark:
philips/light_zll_B.json
: Hue white and color ambiance light :heavy_check_mark:
philips/light_zll_C.json
: Hue white and color ambiance light :heavy_check_mark:
philips/light_zb3_C.json
: Hue white and color ambiance light :heavy_check_mark:
philips/light_zb3_C_festavia.json
: Hue festavia string lights :heavy_check_mark:
philips/light_zb3_C_gradient.json
: Hue white and color ambiance gradient light :heavy_check_mark:
dresden_elektronik/hive.json
: Portable ambient light (Phoscon Hive) :heavy_check_mark:
[!TIP] Everything is fine !
:clock2: Updated for commit 065f6b9bc079055f5db2099c24799899883bc6f0
Not sure why the validation checks fail. These changes pass
ddf-tool validate
locally:$ ddf-tools validate -d devices - Using validator version 2.31.1 ✔ Found 662 files to validate Skipping file devices/danalock/danalock_v3.json because it has the ddfvalidate option set to false Skipping file devices/legrand/cable_outlet.json because it has the ddfvalidate option set to false ✔ Loaded 270 generic files and 390 DDF files from disk ✔ No errors found in 270 generic files ✔ No errors found in 390 ddf files
The issue was because the bundler was not able to find the generic file for attr/otau/imagetype
he was expecting the location generic/items/attr_otau_imagetype_item.json
Updated in https://github.com/dresden-elektronik/deconz-rest-plugin/pull/7961/commits/c672d71219d1d09cccdb9d3b4aec5c69800d3161
To support automated checking if newer firmware is available for a device, the API needs to expose the firmware parameters, Manufacturer Code, Image Type, and File Version. This PR adds support for resource items
cap/otau/manufacturer_code
,cap/otau/image_type
, andcap/otau/file_version
, to be included in DDFs of devices that support OTA firmware upgrades. These items are exposed as a separate map undercapabilities
onlights
andsensors
resources:They're also included as separate map in the
capabilities
websocket notifications.Note that the items are populated from the Query Next Image Request, rather than from the optional (!) OTAU cluster attributes.
cap/otau/manufacturer_code
sends an Image Notify onread
, triggering the Query Next Image Request, which also populates table in the OTA Update panel in the GUI.This PR adds the new items to the DDFs for Hue devices and for some others that I had handy.
TODO:
TODO on the longer term:
attr/otaversion
(based on the OTAU cluster attribute), in favour ofcap/otau/fileversion
? It's used only asmatchexpr
in the DDF for the Trådfri on/off switch (after the attributes are defined on device level, and we've made sure they's persisted in the database).rest_lights.cpp
andrest_sensors.cpp
to build the maps dynamically (cf. websocket notifications forsensors
) rather than listing all items explicitly (see #7979).