dresden-weekly / ansible-network-interfaces

Ansible roles to manage Ubuntu network interface configuration
MIT License
86 stars 62 forks source link

Jinja2 2.9.x broken #46

Closed berendt closed 7 years ago

berendt commented 7 years ago

Looks like Jinja 2.9.x introduced some issue with the groupby filter used in the configurations task:

TASK [network-interfaces : configurations] *************************************
 [WARNING]: Exception in safe_eval() on expr: [_GroupTuple(grouper=u'eth0', ..., "msg": "AnsibleUndefinedVariable: 'unicode object' has no attribute 'device'"}

Tested with Ansible 2.2.0.0 and Jinja2 2.9.3.

tersmitten commented 7 years ago

I think they are already resolved in development

tersmitten commented 7 years ago

https://github.com/ansible/ansible/pull/20014

NicolasLM commented 7 years ago

I confirm that it is fixed, ansible now specifies jinja2 < 2.9.

berendt commented 7 years ago

@NicolasLM In master branch or in all current stable releases?

tersmitten commented 7 years ago
jangrewe commented 7 years ago

Thanks for this issue. I was able to fix it on my machine by removing the pip-installed version of Jinja2, so that Ubuntu's version is used. Didn't know what too look for, before i found this issue.

arBmind commented 7 years ago

Ok, so this is not an issue of this module, but Ansible itself?

Can we close it here?

tersmitten commented 7 years ago

Yes, I would say so

arBmind commented 7 years ago

Ok, I close the issue.