search

dresden-weekly / ansible-network-interfaces

Ansible roles to manage Ubuntu network interface configuration
MIT License
86 stars 62 forks source link

Simple additions #5

Closed starkers closed 8 years ago

starkers commented 8 years ago

Heya

I've added in (and already testing on 1000+ servers) some vlan support plus descriptions etc..

Just noticed your feature/[blah] branch sorry.. will make sure the next PR conforms

arBmind commented 8 years ago

Thank you for your contribution.

I am wondering why you have sorted the keys alphabetically. This is also the order they appear in the config file. So far I grouped them in an order that makes sense.

starkers commented 8 years ago

Happy to add to this role, it was much needed (personally) and makes perfect sense!

About the ordering.. absolutely no reason for me changing them, just wanted to skim the line with my eyes and be certain I didn't miss X (if that makes any sense..)

Really ansible or the interfaces format itself neither care which order (in my experience) it is.. just my OCD I guess lol