ADD support for bonding and the ns search domain

dresden-weekly / ansible-network-interfaces

Ansible roles to manage Ubuntu network interface configuration

MIT License

86 stars 62 forks source link

ADD support for bonding and the ns search domain #8

Closed ntavares closed 8 years ago

arBmind commented 8 years ago

Thanks for the pull request. This looks like a really useful feature. Just two questions:

post-up is an alias to up as far as I know. Why do we need it?
It would be really cool if you could add an example of a bonding setup to the readme. This would help to make your additions more discoverable and the role more user friendly.

ntavares commented 8 years ago

Done. As per the question about post-up: why not? I was actually mapping existing configuration into this role, and that's the way it came out. And if it's supported by debian if-scripts, then why not?

arBmind commented 8 years ago

Looks good now. Thx a lot.