dresende / node-orm2

Object Relational Mapping
http://github.com/dresende/node-orm2
MIT License
3.07k stars 376 forks source link

Global leak detected: i #516

Closed mike-zenith closed 10 years ago

mike-zenith commented 10 years ago

Got mocha error because of the missing 'var' statement

mike-zenith commented 10 years ago

i dont see any reason in this patch that makes this test fail:

  1) Hook beforeCreate if hook method has 1 argument should wait for hook to finish:
     Error: timeout of 500ms exceeded
      at Object.<anonymous> (/home/travis/build/dresende/node-orm2/node_modules/mocha/lib/runnable.js:139:19)
      at Timer.list.ontimeout (timers.js:101:19)
dxg commented 10 years ago

Neither do it; it passes for me locally so must be just a random travis thing. Thanks!