dresende / node-orm2

Object Relational Mapping
http://github.com/dresende/node-orm2
MIT License
3.07k stars 377 forks source link

Add extra props on associations to delete #543

Closed YannickDa closed 9 years ago

YannickDa commented 10 years ago

When we need to delete some record on association, this driver use the $pullAll command. But the $pullAll requires an exact match. So, when the association has some extra properties, we need to include these properties in the pull object.

dxg commented 10 years ago

Thanks,

Do you think you could add one test to verify this behaviour? Otherwise it might be broken again once someone else makes a pull request. Thanks.

YannickDa commented 10 years ago

I'm not very familiar with nodeJS test again... I'll try to implement it but I need time :)

dxg commented 10 years ago

:) sounds good