search

dresende / node-orm2

Object Relational Mapping
http://github.com/dresende/node-orm2
MIT License
3.07k stars 379 forks source link

Test for setting primary key on string ids. #583

Closed chrishoage closed 7 years ago

chrishoage commented 9 years ago

As of right now sqlite3 fails this test and mysql passes.

It appears it does not set the column as a primary key in sqlite3 for text or integer types. If the DB is manually edited primary keys are successfully added to the column.

chrishoage commented 9 years ago

After some digging it appears to be due to this line in the node-sql-ddl-sync.

What is the propose of this if statement? I removed it and that provided the expect query when using key: true as on a type definition.

chrishoage commented 9 years ago

Any word on this issue?