Closed keblodev closed 9 years ago
Because if there's no 'find module' in ex.message ,the -1 value from indexOf is equal to true and you'll never know what hit you.
'find module'
ex.message
-1
indexOf
true
Right now basically on any error thrown in this try {} catch - you'll get "Connection protocol not supported" , which is wrong
try {} catch
"Connection protocol not supported"
Please review.
Good catch. Could you also add a test to orm-exports.js?
yes - sure :)
@dxg , done. Please take a look.
I wish there were 48 hours in the day... sorry for the delay.
Published as part of v2.1.23
Because if there's no
'find module'
inex.message
,the-1
value fromindexOf
is equal totrue
and you'll never know what hit you.Right now basically on any error thrown in this
try {} catch
- you'll get"Connection protocol not supported"
, which is wrongPlease review.