instance.save(function(err, instance) {}) callback signature ?

dresende / node-orm2

Object Relational Mapping

http://github.com/dresende/node-orm2

MIT License

3.07k stars 376 forks source link

instance.save(function(err, instance) {}) callback signature ? #606

Open kapouer opened 9 years ago

kapouer commented 9 years ago

Hi, looking at "instance" code i can see that almost everywhere the callback to .save() is called with (err, instance) signature. This is good, it makes callbacks easier. Except https://github.com/dresende/node-orm2/blob/master/lib/Instance.js#L360 where i suppose it wouldn't hurt to add the missing instance param.