search

dresende / node-orm2

Object Relational Mapping
http://github.com/dresende/node-orm2
MIT License
3.07k stars 379 forks source link

Has one with zero #681

Closed stueynz closed 8 years ago

stueynz commented 8 years ago

I've got a pre-existing database that started all its 'serial' IDs at zero...so I need to allow for Zero as a valid value for FK column in hasOne().

hasValues() is only used in hasOne association, so it's probably ok to make this change.

dxg commented 8 years ago

Looks good and makes sense, however the new tests are failing in postgres :(

stueynz commented 8 years ago

Fixed for postgres....better check sqllite now.

stueynz commented 8 years ago

Fixed it for postgres & sqlite wonder what's wrong for redshift.

stueynz commented 8 years ago

Had to do a silly commit to force Travis to re-try the build. Seems ok now.

dxg commented 8 years ago

:+1:

dxg commented 8 years ago

Released in v2.1.29.