search

dressupgeekout / lunapurpura

Reimplementation of Purple Moon's games from the 1990s (WIP) - NOTE: ScummVM port in progress
https://dressupgeekout.github.io/lunapurpura/
BSD 2-Clause "Simplified" License
8 stars 1 forks source link

PRX: Add the numerical RID to the names of extracted files #44

Closed dressupgeekout closed 4 years ago

dressupgeekout commented 4 years ago

FYI @AlanisSmithee

It turns out there are plenty of examples of PRX members which all have the same name, especially in First Dance. Up until now, the prx(1) tool has been happily overwriting these files with conflicting names.

It's not a bug in the PRX decoder... these filenames (I'm looking inside of Dance's IDGLASS.PRX) literally have truncated names. Rather unfortunate.

I've opted to prepend the RID to the filename, separated by a dash. Seems easy to parse, at least visually. Unfortunately, there are filenames in some PRXes which themselves have dashes, so it's not the easiest thing to script around... I'm open to changing this convention, though. Not sure what's best.

dressupgeekout commented 4 years ago

BTW the fix for https://github.com/dressupgeekout/lunapurpura/issues/19 introduced a merge conflict

I've addressed it but that means I should re-test this functionality before continuing