search

dressupgeekout / lunapurpura

Reimplementation of Purple Moon's games from the 1990s (WIP) - NOTE: ScummVM port in progress
https://dressupgeekout.github.io/lunapurpura/
BSD 2-Clause "Simplified" License
8 stars 1 forks source link

Segfault while decoding IDL/Dana/45004-DANA_kick-it.XPK #60

Open dressupgeekout opened 2 years ago

dressupgeekout commented 2 years ago 
../secret_extract/IDL/Dana/45004-DANA_kick-it.XPK
xpk: decoding entry #0 to 00000-out.png
xpk: decoding entry #1 to 00001-out.png
xpk: decoding entry #2 to 00002-out.png
xpk: decoding entry #3 to 00003-out.png
xpk: decoding entry #4 to 00004-out.png
xpk: decoding entry #5 to 00005-out.png
xpk: decoding entry #6 to 00006-out.png
xpk: decoding entry #7 to 00007-out.png
xpk: ?? unhandled XPK instruction: 0x9E, ftell=36888
bash: line 1: 56698 Segmentation fault: 11  ../../build/src/xpk/xpk -x -p -c ../tricky_extract/IDGlobal/44000-IDPalette.CLU -o out.png ../secret_extract/IDL/Dana/45004-DANA_kick-it.XPK

Might be related to the fact that we don't handle the "0x9" XPK instructions -- worth investigating whether "xpk_biglinerepeat" would actually work

dressupgeekout commented 2 years ago

I'm beginning to think that the code in branch xpk_biglinerepeat actually DTRT

dressupgeekout commented 2 years ago

1e877e113d2bfe810b002318d8f9c2b0fe5702a9 fixes the 45004-DANA_kick-it.XPK case (and all the others that were related to a missing 0x9 instruction) but there are other segfaults -- I'll rename this issue to reflect that