search

dreverri / gollum-site

Static Site Generator for Gollum Wikis
254 stars 28 forks source link

Links to pages don't end in .html #26

Open acgourley opened 11 years ago

acgourley commented 11 years ago

While I know I can fix this with the right webserver config, don't you think the generated links should have .html at the end?

mpemer commented 11 years ago

I have the same issue. Using gollum version 2.4.11 and gollum-site version 0.1.11.

To add a little more context, when entering a gollum page link in the gollum wiki using the format [[some site]], a page is created called some-site and the gollum wiki correctly links to that page. However, when generating the static site using gollum-site, a page called some-site.html is created but the link is rendered as <a class="internal present" href="/./some-page">some page</a>. In order to work properly on any static site hosting provider, the link should be rendered ending with .html. As acgourley states, the issue can be circumvented with web server rules, but not everyone would have ready access to their web server configuration (amazon s3 web site hosting comes to mind).

mpemer commented 11 years ago

After some further investigation this issue is apparently resolved in gollum-site version 0.1.12.

I installed this version on my local machine by cloning the git repo, running rake build, then sudo gem install -V pkg/gollum-site-0.1.12.gem.

I used the -V flag to see in the install ouput where the new gem would be installed. After ensuring that the new version of gollum-site is used, the generated site contains links ending with .html.

A release of version 0.1.12 may be in order.

dreverri commented 11 years ago

I pushed 0.1.12 out today

philippbosch commented 10 years ago

I'm experiencing this issue even with 0.1.12 :-(

philippbosch commented 10 years ago

Well, I just realized that the issue only occurs when I use Markdown-style links ([Some Page](some-page)). When I use the [[Some Page]] link style everything is fine.