Fixed to use correct deploy PR flag with Lagoon CLI 0.30.

sonnykt commented 3 months ago

On-behalf-of: @salsadigitalauorg sonny.kieu@salsa.digital

Checklist before requesting a review

[ ] I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
[ ] I have added a link to the issue tracker
[ ] I have provided information in Changed section about WHY something was done if this was not a normal implementation
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run new and existing relevant tests locally with my changes, and they passed
[ ] I have provided screenshots, where applicable

Changed

Fixed issue with Lagoon CLI 0.30

+ command lagoon --force --skip-update-check -i /root/.ssh/id_rsa_xxx -l amazeeio -p xxx deploy pullrequest -n 1219 --baseBranchName develop -R origin/develop -H feature/XXX -M 5cbf1699887c5cf3092b3ef3e61c344fa51aeec9 -t pr-1219
Error: unknown flag: --baseBranchName
Usage:
  lagoon deploy pullrequest [flags]

Aliases:
  pullrequest, r

Flags:
  -N, --base-branch-name string   Pullrequest base branch name
  -R, --base-branch-ref string    Pullrequest base branch reference hash
      --buildvar stringArray      Add one or more build variables to deployment (--buildvar KEY1=VALUE1 [--buildvar KEY2=VALUE2])
  -H, --head-branch-name string   Pullrequest head branch name
  -M, --head-branch-ref string    Pullrequest head branch reference hash
  -h, --help                      help for pullrequest
  -n, --number uint               Pullrequest number
      --returndata                Returns the build name instead of success text
  -t, --title string              Pullrequest title

Screenshots

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.97%. Comparing base (f9738e7) to head (f643fae). Report is 1 commits behind head on develop.

Files	Patch %	Lines
scripts/drevops/deploy-lagoon.sh	0.00%	2 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (f9738e7) and HEAD (f643fae). Click for more details.

HEAD has 4 uploads less than BASE
| Flag | BASE (f9738e7) | HEAD (f643fae) | |------|------|------| ||13|9|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1368 +/- ## ============================================ - Coverage 67.49% 46.97% -20.52% ============================================ Files 41 41 Lines 3046 3046 ============================================ - Hits 2056 1431 -625 - Misses 990 1615 +625 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AlexSkrypnyk commented 3 months ago

Thank you for your contribution @sonnykt

drevops / vortex