search

drewbkoch / Brackets-File-Icons

File icons in Brackets editor's file tree
74 stars 19 forks source link

New API for File Tree icons #10

Closed dangoor closed 9 years ago

dangoor commented 9 years ago

Brackets 0.44 makes changes to both the working set (#6) and file tree. The bad news is that your extension won't work correctly with the file tree. The good news is that I've created an actual supported API (vs. unsupported DOM manipulation).

I have a rough update to your extension that shows how you can use the API.

We have a pre-release of 0.44 up and it would be great if you can get an update of your extension out within the next week or so. Thanks!

AdriVanHoudt commented 9 years ago

:+1: 0.44 just came out and the icons only show in root of tree now

AdriVanHoudt commented 9 years ago

Commits that updated the original plugin: https://github.com/ivogabe/Brackets-Icons/commit/554638765c6922bdafcc2c11861890746639192a https://github.com/ivogabe/Brackets-Icons/commit/70373822ab7fec898a35afce741f6dbc54a698df https://github.com/ivogabe/Brackets-Icons/commit/39a43406910bc44b81dae7c4271c7f7b6629bc9b (?)

@dangoor does your fix work? If not i might be able to help out, I really like this set more than the original one and changing this font to svg does not work ^^

dangoor commented 9 years ago

@AdriVanHoudt My update should work, though ivogabe's change does a nice job of working with both Brackets 0.43 and 0.44.

It should be fine, though, to use my update and just set the minimum version of the updated extension to 0.44.0.

AdriVanHoudt commented 9 years ago

If it is working maybe do a pull request? Or publish it yourself?

AdriVanHoudt commented 9 years ago

Merge is done so this issue is closed :+1: