search

drewcassidy / KSP-Conformal-Decals

Conformal Decals for KSP
https://forum.kerbalspaceprogram.com/index.php?/topic/194802-*
Creative Commons Attribution Share Alike 4.0 International
16 stars 4 forks source link

Deferred: Blinn-Phong Shininess Factor #46

Open JimmyFiryh opened 5 days ago

JimmyFiryh commented 5 days ago

Firstly, thank you for updating CD to not completely break parts with Deferred.

However, there remains a rather large issue with Deferred-CD compatibility, and it's the Blinn-Phong shininess factor setting missing from its shader definitions. SuicidalInsanity's B9Pwings Fork has a great example of the application of this.

What does this issue mean? Simply put, Conformal Decals are not reflecting the proper skybox, and are simply reflecting direct sources of light. This creates a large disconnect between every other part with this modifier applied, and decals themselves. A good example is below: image All of the pwings, cockpit, and other exposed parts reflect the blue sky, but the decals on the wings & cockpits reflect far more yellow as they only reflect the sun.

Thank you for your time in maintaining this mod, and I hope this can be applied relatively soon.

drewcassidy commented 2 days ago

Yes the currently released version of CD renders in forward mode, so it doesnt get the skybox in reflections. It has nothing to do with blind-phone shininess factor

JimmyFiryh commented 1 day ago

@drewcassidy My apologies then, I only have a surface level knowledge of these things, you know way more than i do on the matter :P

Currently, CD is the final piece of the puzzle to getting the Project Showdown modpack fully working with Deferred. Are you still planning on releasing the full support deferred branch you have cooking? I'm willing to test an unreleased branch if it helps at all.