drewcook / arbor-ui

A collaborative, music-making NFT platform for artists and collectors, built on Ethereum.

https://arbor.audio

GNU General Public License v3.0

7 stars 7 forks source link

fix: voting group IDs from mongodb to on-chain contract #179

Closed Harsh8196 closed 2 years ago

Harsh8196 commented 2 years ago

General Changes

Migrate from off-chain project id to on-chain project id
Fixed on-chain voting issue after new modification

Developer Notes

You can get more information about changes in this report.

Author Checklist

[ ] The base branch is set to main
[ ] The title is using Conventional Commit formatting
[ ] The Github issue has been linked to the PR in the Development section
[ ] The General Changes section has been filled out
[ ] Developer Notes have been added (optional)

Reviewer Checklist

[ ] End-to-end tests are passing without any errors
[ ] Code style generally follows existing patterns
[ ] New third-party packages, if any, do not introduce potential security threats
[ ] There are no CI changes, or they have been OK’d by the devops team
[ ] Code changes have been quality checked in the ephemeral URL
[ ] There is at least one approval from the core team
[ ] Squash and merge has been checked

drewcook commented 2 years ago

@Harsh8196 Do these changes address anything around the Stem IDs? Also, it looks like really we are migrating the votingGroupId in this change, but the issue linked references project and stem IDs, which are the mongodb objectID randomly generated. We definitely want to keep these in and reference them for the details pages like /projects/[id] so they stay unique, and similar to stems. This way we can show details regarding each one.

So is this just an inaccurate description of our issue and PR, and we're really talking about voting group IDs, i.e. semaphore groups? I don't see any changes for projects and stems regarding their ids, as when we create new records, i.e. on the /new page, they'll get auto-generated, which is what we want.

drewcook commented 2 years ago

@Harsh8196 Also, do we want to update or delete the votingGroupId.model.ts and anything related to that? I noticed some of the code is just commented out rather than deleted to. I think its fine to delete if we know the changes are working. We can also reference back with git history, and commented dead code usually just gets in the way.