drewcook / arbor-ui

A collaborative, music-making NFT platform for artists and collectors, built on Ethereum.

https://arbor.audio

GNU General Public License v3.0

7 stars 7 forks source link

fix: Multiples solos plays audio for wrong tracks.#193 #226

Closed 0xlws closed 1 year ago

0xlws commented 1 year ago

General Changes

Fixes "Bug Notes In this project, when selecting a solo, an incorrect sample plays.

Expected Behavior Seems like the behavior should either be to only allow one track to be soloed at a time, or if two tracks are solo'ed only those two tracks should be playing."

Developer Notes

Add any notes here that may be helpful for reviewers.

Author Checklist

[ ] The base branch is set to main
[x] The title is using Conventional Commit formatting
[x] The Github issue has been linked to the PR in the Development section
[x] The General Changes section has been filled out
[ ] Developer Notes have been added (optional)

Reviewer Checklist

[ ] End-to-end tests are passing without any errors
[ ] Code style generally follows existing patterns
[ ] New third-party packages, if any, do not introduce potential security threats
[ ] There are no CI changes, or they have been OK’d by the devops team
[ ] Code changes have been quality checked in the ephemeral URL
[ ] There is at least one approval from the core team
[ ] Squash and merge has been checked

vercel[bot] commented 1 year ago

@0xlws is attempting to deploy a commit to the Arbor Protocol Team on Vercel.

A member of the Team first needs to authorize it.