drewcook / arbor-ui

A collaborative, music-making NFT platform for artists and collectors, built on Ethereum.

https://arbor.audio

GNU General Public License v3.0

7 stars 7 forks source link

fix: reposition recent projects #229

Closed noahdahlman closed 1 year ago

noahdahlman commented 1 year ago

General Changes

Reposition RecentProjectActivity component below banner image.
Update RecentProjectActivity component styles to center the title and add a border.
Hide scrollbar but keep scroll functionality.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ui	✅ Ready (Inspect)	Visit Preview	Dec 18, 2022 at 10:43AM (UTC)

drewcook commented 1 year ago

I have a few things as feedback on how this initially got implemented. I'd like the get them addressed in this PR as a follow-up.

The initial PR got merged in without my feedback at all, and the way the projects are getting are wrong - it should limit the results to 3. I think it needs to be moved to it's own route, and or the params passed in need to be ensured that they are working on the records correctly, or if they need to be translated to direct mongoose helper methods and moved to its own route, like /projects/recent, which always returns the latest three.

drewcook commented 1 year ago

Another feedback item is how <Card> is used in this. It's applied as a top-level global component, then maps over the projects and renders the appropriate ProjectCard, which is also a card. So this isn't ideal. The top level card compoennt, card header, card contents, IMO should be split up to a <section>, for the overall topmost component for RecentProjectActivity, as it's used on the homepage, and the title can just be a typography h3 or whatever and the subtext another typography centered. Then the cards don't have to be wrapped in anything after that. So this will remove Card, CardContent, CardHeader from the component.

drewcook commented 1 year ago

Closing in favor of #232