Feat/zk auctions #188 - Githubissues

drewcook / arbor-ui

A collaborative, music-making NFT platform for artists and collectors, built on Ethereum.

https://arbor.audio

GNU General Public License v3.0

7 stars 7 forks source link

Feat/zk auctions #188 #248

Open 0xlws opened 1 year ago

0xlws commented 1 year ago

General Changes

Implemented zero-knowledge blind auction feature as described in ZK Blind Auction by heivenn into #188

Fixes

Fixed XYZ bug

Adds

Added anonymous voting using zkSNARKs

Developer Notes

The POC currently only accepts 4 bids, inherited from ZK Blind Auction. This should be addressed in future updates
The first .zkey was generated with the publicly available ptau28 Power 10 file from Hermez.
The NFT transfer to the winning bid is not visible in the UI, issue is likely in the smart contract transfer or database registration.

Author Checklist

[ ] The base branch is set to main
[ ] The title is using Conventional Commit formatting
[ ] The Github issue has been linked to the PR in the Development section
[ ] The General Changes section has been filled out
[ ] Developer Notes have been added (optional)

If the PR is ready for review:

[ ] The PR is in Open state and not in Draft mode
[ ] The Ready for Dev Review label has been added

Reviewer Checklist

[ ] End-to-end tests are passing without any errors
[ ] Code style generally follows existing patterns
[ ] New third-party packages, if any, do not introduce potential security threats
[ ] There are no CI changes, or they have been OK’d by the devops team
[ ] Code changes have been quality checked in the ephemeral URL
[ ] There is at least one approval from the core team
[ ] Squash and merge has been checked