Closed Alizter closed 8 months ago
Here is an example of how it can look today:
We should probably add configuration for all of the colors with sane defaults. We should probably nest them under a colors section in the config.
My instinct is that we need to provide a colors
section of the config that maybe has the following options.
true
/false
16
, 256
, 24bit
(this of course depends on what color library supportsI think that the configuration options described here are nice, but I wouldn't regard them as strictly necessary. I think just an enabled/disabled option should be enough for the next release.
We talked about this in Slack and we netted that we should probably just start with 24bit color mode support and if someone isn't using a term that supports it then they can for the time being disable color all together. In the future we will potentially try and figure out supporting 256 color mode and 16 color mode.
We also discussed an initial structuring of the config related to colors such that we would have something like the following.
[colors]
warning_foreground_color =
[list]
patch_series_background_color =
patch_series_foreground_color =
patch_series_index_foreground_color =
patch_series_sha_foreground_color =
patch_series_summary_color =
alternate_patch_series_background_color =
alternate_patch_series_foreground_color =
alternate_patch_series_index_foreground_color =
alternate_patch_series_sha_foreground_color =
alternate_patch_series_summary_color =
...
this has been integrated into main
with shas d00aea5, 3482d86, and 0bb5349. Therefore, I am closing this issue.
We should add two configuration options for the alternating background color when you do
gps ls
.