add config option for alternating background color in gps ls

drewdeponte / git-ps-rs

Official git-ps Rust implementation - the future of git-ps

https://git-ps.sh

MIT License

78 stars 8 forks source link

add config option for alternating background color in gps ls #283

Closed Alizter closed 8 months ago

Alizter commented 9 months ago

We should add two configuration options for the alternating background color when you do gps ls.

The color value of the background. We could stick to ansi 256 or just allow a hex value 0xffffff a la web.
Enabling and disabling the colouring all together. Some terminals have transparent backgrounds so no background color looks best.

Alizter commented 9 months ago

Here is an example of how it can look today:

drewdeponte commented 9 months ago

We should probably add configuration for all of the colors with sane defaults. We should probably nest them under a colors section in the config.

drewdeponte commented 8 months ago

My instinct is that we need to provide a colors section of the config that maybe has the following options.

enabled: true/false
mode: 16, 256, 24bit (this of course depends on what color library supports
patch_series_color - color for the patch series (depends on mode)
alternating_patch_series_color - color for alternating patch series (depends on mode)
patch_index - color for the patch index
patch_sha - color for the patch sha
patch_summary - color for the patch summary
etc...

Alizter commented 8 months ago

I think that the configuration options described here are nice, but I wouldn't regard them as strictly necessary. I think just an enabled/disabled option should be enough for the next release.

drewdeponte commented 8 months ago

We talked about this in Slack and we netted that we should probably just start with 24bit color mode support and if someone isn't using a term that supports it then they can for the time being disable color all together. In the future we will potentially try and figure out supporting 256 color mode and 16 color mode.

We also discussed an initial structuring of the config related to colors such that we would have something like the following.

[colors]
warning_foreground_color =

[list]
patch_series_background_color =
patch_series_foreground_color =
patch_series_index_foreground_color =
patch_series_sha_foreground_color =
patch_series_summary_color =
alternate_patch_series_background_color =
alternate_patch_series_foreground_color =
alternate_patch_series_index_foreground_color =
alternate_patch_series_sha_foreground_color =
alternate_patch_series_summary_color =
...

drewdeponte commented 8 months ago

this has been integrated into main with shas d00aea5, 3482d86, and 0bb5349. Therefore, I am closing this issue.