search

drewdeponte / git-ps-rs

Official git-ps Rust implementation - the future of git-ps
https://git-ps.sh
MIT License
78 stars 8 forks source link

Fix op ssh signing #292

Closed alondahari closed 6 months ago

alondahari commented 7 months ago

Addresses #290

The commits in this PR have all been signed by 1Password's ssh signing integration.

When using a local SSH key generated by ssh-keygen, we get a message in the console from ssh-keygen: "Signing data on standard input". This seems to be the result of how we sign the commits (from stdin), and it's not a warning, but I'm not sure what we can do about that. Other than create a buffer to sign instead, like git does.

Did not address the issues around errors bubbling up and panic in cherry_picking.rs, probably should go into separate issues.

drewdeponte commented 6 months ago

@alondahari Only thing I noticed where those few comments about defaulting. It would just be good to true it up in terms of matching Git proper behavior in terms of configuration.