search

drewdeponte / git-ps

Patch Stack workflow CLI extension for Git
MIT License
50 stars 4 forks source link

No longer force push to origin/master as part of the publish command #2

Closed drewdeponte closed 4 years ago

drewdeponte commented 4 years ago

I noticed that currently we have publish doing a force push to origin/master and this seemed unsafe. It seems like if someone else has published chages to origin/master in-between the process of running of the publish command running it would result in use changing history of the remote. Even though this is unlikely that this happen in that small window of time I still think we should make sure we can't change the remotes history.

drewdeponte commented 4 years ago

So the conclusion is NO we shouldn't be doing a force push.

drewdeponte commented 4 years ago

I dog into this and it is actually using force push in the correct place to push the rr branch up to the remote, and then using NON force push to publish the patch up to origin/master.

Therefore, I am closing this bug and marketing it won't fix because there is nothing to do as it is actually correct.