search

drewdeponte / octopusci

A multi-branch continuous integration server
MIT License
19 stars 2 forks source link

If the command outputs to stderr and you don't have 2>&1 in your cmd then it causes a failure #50

Open drewdeponte opened 12 years ago

drewdeponte commented 12 years ago

It does this even if a warning is just output to the stderr. I think that the reasoning for this is because IO.popen() doesn't support stderr capturing and therefore when it tries to write to stderr it throws an IO Error.

The solution to fixing this problem is switching to popen2 or popen3 or something similar that provides the stdin, stdout, and stderr streams so that we don't get incorrect failures for this reason.

oreoshake commented 12 years ago

+1 for popen 2/3 if that fixes the problem. The more output the better. On Jan 6, 2012 10:29 AM, "Andrew De Ponte" < reply@reply.github.com> wrote:

It does this even if a warning is just output to the stderr. I think that the reasoning for this is because IO.popen() doesn't support stderr capturing and therefore when it tries to write to stderr it throws an IO Error.

The solution to fixing this problem is switching to popen2 or popen3 or something similar that provides the stdin, stdout, and stderr streams so that we don't get incorrect failures for this reason.

Reply to this email directly or view it on GitHub: https://github.com/cyphactor/octopusci/issues/50

drewdeponte commented 12 years ago

http://ruby-doc.org/stdlib-1.9.3/libdoc/open3/rdoc/Open3.html