search

drewdeponte / snapdragon

A Jasmine JavaScript test runner that lets you run tests on the command-line similar to RSpec.
Other
6 stars 8 forks source link

Added the ability to pass a debug flag to phantom #39

Closed BRIMIL01 closed 8 years ago

BRIMIL01 commented 9 years ago

I did this to allow for easier debugging of issues with phantom running jasmine tests.

Replaces PR #38

BRIMIL01 commented 9 years ago

This was tested with phantomjs 1.8.2

BRIMIL01 commented 9 years ago

If poltergeist is upgraded to 1.6.0 it will throw the following error: /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/poltergeist-1.6.0/lib/capybara/poltergeist/browser.rb:60:in find': undefined methodmap' for nil:NilClass (NoMethodError) from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/poltergeist-1.6.0/lib/capybara/poltergeist/driver.rb:120:in find' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/poltergeist-1.6.0/lib/capybara/poltergeist/driver.rb:128:infind_css' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/node/base.rb:102:in find_css' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/query.rb:108:inblock in resolve_for' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/node/base.rb:80:in synchronize' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/query.rb:106:inresolve_for' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/node/finders.rb:32:in block in find' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/node/base.rb:84:insynchronize' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/node/finders.rb:30:in find' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/gems/capybara-2.4.4/lib/capybara/session.rb:676:inblock (2 levels) in class:Session' from /Users/brian.miller/dev/snapdragon/lib/snapdragon/cli_application.rb:34:in run' from /Users/brian.miller/dev/snapdragon/bin/snapdragon:11:in<top (required)>' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/bin/snapdragon:23:in load' from /Users/brian.miller/.rbenv/versions/1.9.3-p551/lib/ruby/gems/1.9.1/bin/snapdragon:23:in

'

BRIMIL01 commented 9 years ago

FWIW the debug mode works great :-)

drewdeponte commented 9 years ago

@BRIMIL01 so I was able to test it this time and things look good except for one thing. The snapdragon_server command doesn't seem to respect debug mode even though it has the command line option in its help message. At least I don't see any difference when I test it. What should the difference be. I checked console log messages, etc. but nothing.

drewdeponte commented 8 years ago

No activity has happened on this since the last comment, so I am closing this pr. It can be reopened if discussion is picked back up.