Update soundEnum for 1.13+

drewdorris / Powder

A Spigot plugin which utilizes particles & sound effects to allow for incredibly customizable pictures and animations

Other

15 stars 3 forks source link

Update soundEnum for 1.13+ #6

Closed ds58 closed 5 years ago

ds58 commented 5 years ago

The soundEnum option in the default powders.yml is using old 1.12 enum values. A lot of them, especially relating to note sounds have broken. There should be some compatibility between 1.12 and 1.13+ here

drewdorris commented 5 years ago

NoteBlockAPI handles this https://github.com/koca2000/NoteBlockAPI/blob/master/src/main/java/com/xxmicloxx/NoteBlockAPI/model/Sound.java https://github.com/Ruinscraft/Powder/blob/master/src/main/java/com/ruinscraft/powder/util/ConfigUtil.java#L253

ds58 commented 5 years ago

oh nice 👍