search

drewg13 / foundryvtt-openlegends

GNU General Public License v3.0
1 stars 1 forks source link

Lethal damage Cap #3

Closed JacobfromAVS closed 8 months ago

JacobfromAVS commented 8 months ago

Lethal damage does not cap at 10. It should cap at the max HP of the character. The rest of lethal damage is working as it supposed to.

drewg13 commented 8 months ago

This is more complicated than I thought. It might take a minute to figure it out. The method previously used to set caps and controls is causing some of these issues and it's hard to tell how it's supposed to work.

drewg13 commented 8 months ago

Hahahahaha, no it was much simpler. The hp.lethal was dependent on hp.max as an upper limit, but the hp.max calculation came after the hp.lethal calculation, so it defaulted to 10. In the process, I found a different issue where setting the attributes in the cog popup window isn't always sticking, so I'll work that one out before releasing.

drewg13 commented 8 months ago

I think I got it all, should be in the next version.