search

drewg13 / foundryvtt-scum-and-villainy

Scum and Villainy game system for FoundryVTT
Other
12 stars 15 forks source link

Convert clocks to svg and circles. #70

Closed jparks closed 1 year ago

jparks commented 1 year ago

Removed transparency from clocks. This fixes visibility issues when using them as tiles on backgrounds that are bright and/or colorful.

Made the clocks round to match the style of Global Progress Clocks.

drewg13 commented 1 year ago
  1. I can see why transparency might be an issue in some circumstances, but replacing it with white isn't strictly better in 100% of circumstances either. I tend to use my clocks on a black background and the white looks awful to me there.
  2. I'm not clear why matching the style of Global Progress Clocks is sufficiently desirable to demand a complete gut replacement. My intention was to match the clock style used in the factions section of the rulebook as closely as possible. Since you haven't made any actual arguments here, practical or aesthetic, I'm going to pass.

You're welcome to re-format this as a set of optional themes, since this sort of thing is precisely why I included the theming code. I'd at least consider merging that instead. As it stands, this just looks like you're insisting on everyone using your personal preferences instead.

jparks commented 1 year ago

Progress clocks and healing clocks are round in the rulebook. Other modules, such has Global Progress Clocks, provide round clocks as well. Having consistent looking progress clocks throughout a game that I can see is a personal preference ;-p

Moving them to a theme is a great idea.