search

drewjbartlett / vue-flickity

A Vue Slider / Carousel Component for Flickity.js
http://drewjbartlett.com/demos/vue-flickity/
374 stars 55 forks source link

Changed "beforeDestroy" to "afterDestroy" #17

Closed groman00 closed 7 years ago

groman00 commented 7 years ago

Destroying flickity instance on component's afterDestroy lifecycle event. Prevents widget from visibly losing styles when component exists in a router-view with transition effects.

citrus commented 7 years ago

👍

chasegiunta commented 7 years ago

afterDestroy() and destroy() aren't lifecycle hooks. This just doesn't call vue-flickity's destroy() method at all.

groman00 commented 7 years ago

@chasegiunta Yea you're right, it was a typo. Correcting the hook name to "destroyed" re-introduces the problem. This PR is totally useless. Closing it.