search

drewkeller / redmine_digest

A plugin for the Redmine issue tracking system which emails a digest of the project's activity to its members.
Other
29 stars 17 forks source link

Get_recipients crashes if project member is a group #31

Open Webovani opened 11 years ago

Webovani commented 11 years ago

If member.user_id points to Group, member.user is nil and DigestMailer.get_recipients crashes.

Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:166:in `get_recipients'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:164:in `each'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:164:in `get_recipients'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:213:in `digests'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:194:in `each'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:194:in `digests'
janthurau commented 10 years ago

Should be fixed by PR #37