drewmccormack / ensembles

A synchronization framework for Core Data.
MIT License
1.63k stars 131 forks source link

README.md: IDMICloudContainerIdentifier instruction not clear #123

Closed ylin closed 10 years ago

ylin commented 10 years ago

In Step 5 of Idiomatic App setup under README.md, it says

At the top of the IDMSyncManager class, locate this code

NSString * const IDMICloudContainerIdentifier = 
@"P7BXV6PHLD.com.mentalfaculty.idiomatic";

Fill in the Ubiquity Container Identifier appropriate for your bundle 
identifier and team identifier. You can find this on the iOS Developer 
Center under the App ID you registered. Just combine the Prefix 
entry with the ID.

Shouldn't the default setting of that line in the .m file be just:

NSString * const IDMICloudContainerIdentifier = nil;

?

This will work for developers without custom ubiquity container, and then we can move instruction for setting custom ubiquity container into an advanced configuration section.

On the Mac Idiomatic app setup (undocumented), it is use nil by default for the ubiquity container, which works out of the box as long as user has added a container name under the Capabilities > iCloud section in Xcode project setting.

drewmccormack commented 10 years ago

Thanks, it is a good point. I tend to explicitly set the id, but you are right that for most people the default is fine.

I will look at removing that instruction.

ylin commented 10 years ago

thanks

On Mar 29, 2014, at 4:01 AM, Drew McCormack notifications@github.com wrote:

Thanks, it is a good point. I tend to explicitly set the id, but you are right that for most people the default is fine.

I will look at removing that instruction.

— Reply to this email directly or view it on GitHub.