search

drewmccormack / ensembles

A synchronization framework for Core Data.
MIT License
1.63k stars 131 forks source link

Ensemble for Mac: 10.7? #151

Closed InerziaSoft closed 10 years ago

InerziaSoft commented 10 years ago

I see in the project that the deployment version is 10.7 (from build settings), but the code makes use of the UbiquityIdentityToken method of FileManager, available from 10.8. So I think that the deployment version should be 10.8, right? (anyway... very good work!)

drewmccormack commented 10 years ago

Good point. I will make it work on 10.7. Thanks.

drewmccormack commented 10 years ago

Fixed in 31fdb11de3d7ac20c5a40b320435f3dbf24a9712

InerziaSoft commented 10 years ago

I think there is yet another reference to 10.8 only in CDESaveMonitor.m, line 33 (I think "weakToStrong..." could be substituted by "cde_weakToStrong"..., by adding the corresponding category header).

InerziaSoft commented 10 years ago

Ok, it is more difficult than what it seemed... I have a crash immediately on start the Ensemble object on 10.7.5 with such a trace:

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000

VM Regions Near 0: --> __TEXT 000000010134a000-0000000101373000 [ 164K] r-x/rwx SM=COW /Users/USER/Desktop/myApp.app/Contents/MacOS/myApp

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.mentalfaculty.ensembles 0x000000010139f4a4 -[CDEEventStore createEventStoreDirectoriesIfNecessary:] + 420 1 com.mentalfaculty.ensembles 0x000000010139ee97 -[CDEEventStore prepareNewEventStore:] + 50 2 com.mentalfaculty.ensembles 0x00000001013cb803 -[CDEPersistentStoreEnsemble setupEventStoreWithCompletion:] + 172 3 com.mentalfaculty.ensembles 0x00000001013caba5 __65-[CDEPersistentStoreEnsemble leechPersistentStoreWithCompletion:]_block_invoke278 + 118 4 com.mentalfaculty.ensembles 0x00000001013bd5d1 -[CDEAsynchronousTaskQueue startNextTask] + 491

It never happened to me such an error and I'm not deep inside your code; I know that 10.8/10.9 are very different from Lion, so it could be a huge work to make it work also there. So I'm thinking to leave out Lion compatibility.

drewmccormack commented 10 years ago

I have been testing a newer version on 10.7 all day, and it has been working. I must have missed something back porting. It can certainly work, and I need it in my 10.7 app, so I will fix it tomorrow.

Drew

On 17 Jun 2014, at 00:03, InerziaSoft notifications@github.com wrote:

Ok, it is more difficult than what it seemed... I have a crash immediately on start the Ensemble object on 10.7.5 with such a trace:

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000

VM Regions Near 0: --> __TEXT 000000010134a000-0000000101373000 [ 164K] r-x/rwx SM=COW /Users/USER/Desktop/myApp.app/Contents/MacOS/myApp

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.mentalfaculty.ensembles 0x000000010139f4a4 -[CDEEventStore createEventStoreDirectoriesIfNecessary:] + 420 1 com.mentalfaculty.ensembles 0x000000010139ee97 -[CDEEventStore prepareNewEventStore:] + 50 2 com.mentalfaculty.ensembles 0x00000001013cb803 -[CDEPersistentStoreEnsemble setupEventStoreWithCompletion:] + 172 3 com.mentalfaculty.ensembles 0x00000001013caba5 __65-[CDEPersistentStoreEnsemble leechPersistentStoreWithCompletion:]_block_invoke278 + 118 4 com.mentalfaculty.ensembles 0x00000001013bd5d1 -[CDEAsynchronousTaskQueue startNextTask] + 491

It never happened to me such an error and I'm not deep inside your code; I know that 10.8/10.9 are very different from Lion, so it could be a huge work to make it work also there. So I'm thinking to leave out Lion compatibility.

— Reply to this email directly or view it on GitHub.