search

drewmccormack / ensembles

A synchronization framework for Core Data.
MIT License
1.63k stars 131 forks source link

Idiomatic Sample App for Mac #26

Closed erndev closed 11 years ago

erndev commented 11 years ago

Not really an issue, but a question.

I've coded a sample Mac app to test Ensemble, adding a target "IdiomaticMac" in current's sample project. since it's a big change and i don't know if you may have planned already a Mac version of the test app, i thought i'd ask first before sending a pull request. It's currently working quite fine and sharing Notes with iOS version of the app just fine.

Since is just for test, i put most of the code in the app delegate instead of creating different controllers.

you can have a look at it in this branch of my fork of Ensembles

https://github.com/erndev/ensembles/tree/IdiomaticMac

Let me know if you find it interesting and i can send the pull request. Also, any changes/improvements/suggestions are appreciated.

cheers

drewmccormack commented 11 years ago

Looks great. Well done. Worked fine for me (once I sorted out some code signing issues that were my fault.)

If you are happy to contribute this, send me a pull request.

The code looks pretty clean already. Maybe just tighten up the naming of classes etc in line with the iOS app (e.g. use IDM prefix).

I will probably do a sweep of the code when I pull it in anyway, but it already looks very readable.

Thanks!

erndev commented 11 years ago

Yes, keeping the code signing and containers is a bit of a headache. In order to commit to github, i had to make sure to remove my signing identity, and setting back your sample's container.

I'll rename the classes to add the IDM prefix where missing and send a pull request.

By the way, i just read that you already have a dropbox version. I began creating an implementation last night, but i better wait for yours :-)