search

drewmccormack / ensembles

A synchronization framework for Core Data.
MIT License
1.63k stars 132 forks source link

Support for Core Data changes on iOS 11 #260

Closed keremerkan closed 6 years ago

keremerkan commented 6 years ago

Workaround for binary store changes on iOS 11. A better way to do this should be using NSBinaryStoreSecureDecodingClasses option in the future.

drewmccormack commented 6 years ago

Did merge this, but have reset the master branch to remove it for now. The problem was that the code does not compile in Xcode 8, or with the current SDK. Since Xcode 9 and iOS 11 are betas, I don't want to leave everyone behind. Will wait and make the change when release has been established and most people moved over.

keremerkan commented 6 years ago

Sure. I would suggest a branch for Xcode 8 and merging this immediately to master when Xcode 9 is released though. Because the error is silent enough to dismiss on Xcode 9 if you are not looking, which will result in disabled functionality as we discussed earlier.

drewmccormack commented 6 years ago

How do you mean? The master as it is works, correct? I do pass in the right parameter. The new pull request is just nicer because it uses the correct constant. Right?

Kind regards, Drew

On 10 Sep 2017, at 13:43, keremerkan notifications@github.com wrote:

Sure. I would suggest a branch for Xcode 8 and merging this immediately to master when Xcode 9 is released though. Because the error is silent enough to dismiss on Xcode 9 if you are not looking, which will result in disabled functionality as we discussed earlier.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

keremerkan commented 6 years ago

Actually, I had only tried your version on iOS 11, that's why I am not sure if this will be a problem, but wouldn't it create problems or unknown behavior to pass a parameter that does not exist to a store when creating it? As the parameter does not exist on earlier iOS versions, perhaps the store could behave unexpectedly. Even though you don't use the symbol, I think at least iOS version control should be there for peace of mind. I haven't tested any of this though, so maybe it will not create any problems with its current state.

drewmccormack commented 6 years ago

I doubt that an extra unknown parameter will cause any issue. It will just ignore it, I would expect. I think what we have is fine for now, and I will move to your solution when Xcode 9 is final.

keremerkan commented 6 years ago

OK then. I’ll also create a pull request for recommended project settings for Xcode 9 shortly. Perhaps you can commit both, when the time comes. Cheers!