Kellyroach/fix warnings

[kellyroach]

This pull request fixes assorted Xcode 9.4.1 compiler warnings.

• Remove 'Ensembles iOS.xcodeproj' in Resources
• Remove bqnnqguhepfxlkgqvdamggjewche directory from FRAMEWORK_SEARCH_PATHS
• viewDidUnload is deprecated
• Fix 'A 1024x1024 app store icon is required for iOS apps' warning
• Fix block implicitly retains 'self' warnings
• Xcode 9.4.1 Update 3 projects to recommended settings
• Fix 'nil passed to a callee that requires a non-null 1st parameter' Analyze warning

We noticed but we did not also fix:

• "240 issues" in "Tests Mac", mostly "Block implicitly retains 'self'" warnings.
• object of type 'id<NSObject,NSCopying,NSCoding>' is not compatible with array element type 'MCPeerID *' -- We're afraid to touch this one since it involves MCPeerID .

[kellyroach]

UNIT TESTS

CASE: "Ensembles iOS Library" / "iPhone X:

• "Tests iOS 250 tests" PASSED

  Test Suite 'Tests iOS.xctest' passed at 2018-07-06 19:01:48.249.
   Executed 250 tests, with 0 failures (0 unexpected) in 27.269 (27.972) seconds

CASE: "Ensembles Mac Framework" / "My Mac"

• "Tests Mac 250 tests" PASSED

  Test Suite 'Tests Mac.xctest' passed at 2018-07-06 19:05:25.040.
   Executed 250 tests, with 0 failures (0 unexpected) in 25.621 (25.796) seconds

[kellyroach]

MANUAL TEST

Following along with the README.md "Idiomatic App" instructions.

• We make these unchecked in changes to get personal bundle identifier and signing

  Bundle Identifier = com.planetquantum.idiomatic
  Team = Kelly Roach

• In "iPhone X" Simulator, use the "Settings" in Simulator to

  Sign in to your iPhone
  Set up iCloud, the App Store, and more.

  We sign into iCloud using our basic authentication credentials and 2 factor.

• Launch app on "iPhone X" simulator
• Add 2 notes, 1 photo, 2 groups
• "Enable Sync" / "iCloud"
• Stop app in Xcode IDE
• Launch on real device
• "Enable Sync" / "iCloud" Content we entered on "iPhone X" simulator is now on our real "iPhone 5S" device.

Amongst Xcode Console output while engaging "Enable Synch" on the simulator, we saw:

-[CDECloudManager transferFilesInTransitCacheToRemoteDirectory:completion:]_block_invoke_2 line 446: Uploading file to remote path: ...]

CONCLUDE: This made us happy with iOS

REGARDING: macOS AND "Idiomatic Mac" / "Build Settings"

• Temporarily changed without checking in "Product Bundle Identifier" to com.planetquantum.idiomatic.osx
• Apple Dev Center https://developer.apple.com/account/mac/identifier/bundle/ "Edit" "XC com planetquantum idiomatic osx" "iCloud Container Assignment" Currently "0 of 2 item(s) selected" We choose to "Select All" "Continue" "Assign" "You have successfully modified your iCloud Containers"
• It's also necessary to change two occurrences of "iCloud.com.mentalfaculty.idiomatic" --> "iCloud.com.planetquantum.idiomatic" in "IdiomaticMac.entitlements"
• The app launches and looks OK. Our understanding from a STACKOVERFLOW.COM article is we would need a published and approved app to enable sharing a cloud container between iOS and macOS apps. We didn't go that far.

CONCLUDE: That's it for our macOS testing.

[drewmccormack]

Thanks! Nice job