search

drewmccormack / ensembles

A synchronization framework for Core Data.
MIT License
1.63k stars 131 forks source link

Push 1.7.2 and 1.8 to Cocoapods Trunk #282

Closed UberJason closed 5 years ago

UberJason commented 5 years ago

Hey Drew! I noticed recently that you had a couple of releases (1.7.2 in April 2018 and 1.8 just a couple weeks ago) which haven't been pushed to Cocoapods trunk, meaning when we try to install Ensembles by Cocoapods, the system only sees 1.7.1 as the latest. Would you mind doing those quick pod trunk push commands to update the Cocoapods Spec repo?

drewmccormack commented 5 years ago

I wasn’t able to get it to push to cocoapods, I’m afraid. Was failing for some odd reason to do with SSZipArchive.

If you can get that working, I’m happy to push it.

Drew

On 6 Apr 2019, at 16:56, Jason Ji notifications@github.com wrote:

Hey Drew! I noticed recently that you had a couple of releases (1.7.2 in April 2018 and 1.8 just a couple weeks ago) which haven't been pushed to Cocoapods trunk https://github.com/CocoaPods/Specs/tree/master/Specs/b/d/c/Ensembles, meaning when we try to install Ensembles by Cocoapods, the system only sees 1.7.1 as the latest. Would you mind doing those quick pod trunk push commands to update the Cocoapods Spec repo?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drewmccormack/ensembles/issues/282, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEuALfGlQ-wUbmfyU7X5Ihd-Y1o0S20ks5veLWsgaJpZM4cgPcP.

UberJason commented 5 years ago

Funny you mentioned that - I tried pulling in the latest Ensembles directly from your GitHub URL, and I get an error in CDEMultipeerCloudFileSystem.m:

Screen Shot 2019-04-06 at 12 02 47 PM

I wonder if it's related?

drewmccormack commented 5 years ago

Yes, certainly related. SSZipArchive is a mess. It was a separate framework, now it is included in ZipArchive. But I can’t find a combination of imports/frameworks etc that seems to work.

Will take another look.

Drew

On 6 Apr 2019, at 18:07, Jason Ji notifications@github.com wrote:

Funny you mentioned that - I tried pulling in the latest Ensembles directly from your GitHub URL, and I get an error in CDEMultipeerCloudFileSystem.m:

https://user-images.githubusercontent.com/5779307/55672052-7ab27380-5864-11e9-8513-0e305103ec18.png I wonder if it's related?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drewmccormack/ensembles/issues/282#issuecomment-480515886, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEuAJUZkmmVrpWAiI2JEoaH5CrInzBfks5veMY5gaJpZM4cgPcP.

drewmccormack commented 5 years ago

Think this is now fixed. Should be updated in CocoaPods.

Drew

On 6 Apr 2019, at 18:07, Jason Ji notifications@github.com wrote:

Funny you mentioned that - I tried pulling in the latest Ensembles directly from your GitHub URL, and I get an error in CDEMultipeerCloudFileSystem.m:

https://user-images.githubusercontent.com/5779307/55672052-7ab27380-5864-11e9-8513-0e305103ec18.png I wonder if it's related?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drewmccormack/ensembles/issues/282#issuecomment-480515886, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEuAJUZkmmVrpWAiI2JEoaH5CrInzBfks5veMY5gaJpZM4cgPcP.

UberJason commented 5 years ago

Looking great, thank you! I'm still having an issue with the Ensembles dyld not loading in my main project, but I think that's something up with my project setup in particular - when I create a new sample project and include Ensembles, everything is fine.

drewmccormack commented 5 years ago

Ensembles in CocoaPods is not using a dynamic library. It is static.

The repo has a dynamic build option.

Drew

On 6 Apr 2019, at 23:09, Jason Ji notifications@github.com wrote:

Looking great, thank you! I'm still having an issue with the Ensembles dyld not loading in my main project, but I think that's something up with my project setup in particular - when I create a new sample project and include Ensembles, everything is fine.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drewmccormack/ensembles/issues/282#issuecomment-480537801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEuAD_QY9hq-1FrT7JwAw9U-WFxVUjZks5veQzxgaJpZM4cgPcP.

UberJason commented 5 years ago

Ensembles is not using a dynamic library, but I think Cocoapods makes it available as a dynamic library? I'm not sure - this stuff is over my head - but the error is dyld: Library not loaded: ... reason: image not found. It was working for me using Cocoapods 1.5.3, but not with 1.6.1, so I'm currently trying to isolate the issue and submit it to Cocoapods to see if I'm doing something bad that used to be tolerated and isn't anymore, or if it's a regression in Cocoapods.