search

drewnoakes / metadata-extractor-dotnet

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Other
934 stars 165 forks source link

GeoTIFF fixes + add test #324

Closed don-vip closed 7 months ago

don-vip commented 2 years ago

Ported bug fixes and tests from https://github.com/drewnoakes/metadata-extractor/pull/586

I got a behaviour difference between Java and .NET regarding the description of TagGeoTiffGeoKeys, I had to comment this check to get the test to pass, I don't understand why:

    //Assert.Equal("[32 values]", exif.GetDescription(ExifDirectoryBase.TagGeoTiffGeoKeys));
drewnoakes commented 2 years ago

This looks great with one caveat: we don't add test images to this repo. Instead, we add them to https://github.com/drewnoakes/metadata-extractor-images, where the regression tests track changes over time from each of the Java and .NET implementations, along with a diff of the outputs from each. Ideally they should produce the same values.

Adding images to this repo (or the Java repo) increase the size significantly.

drewnoakes commented 7 months ago

I moved the code changes here to #374. Thanks again!

don-vip commented 7 months ago

Thank you!