search

drewnoakes / metadata-extractor-dotnet

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Other
922 stars 164 forks source link

Fix Exif thumbnail offset #333

Closed drewnoakes closed 1 year ago

drewnoakes commented 1 year ago

Fixes #35

The offset is currently reported relative to the start of the Exif data. However, most users will need the value relative to the start of the outermost data stream. This change attempts to provide that value.

Should work for JPEG and RAW files. Won't work for Exif data embedded within other formats such as PNG, QuickTime, WebP or HEIF. Such support could be added in future.

kwhopper commented 1 year ago

This issue and others like it are mitigated through #131 as it’s embedded in the design.

It’s very old now and introduces many other changes, but decided to offer it for revival once more. Thanks.

drewnoakes commented 1 year ago

I haven't forgotten that work @kwhopper. It's a big change and requires a lot of review, especially around performance, while this is just a quick, surgical, and imperfect change.

Note to self, pick up review of:

kwhopper commented 1 year ago

Thanks. I’m happy to help with it again if it lands on your radar.