drewnoakes / metadata-extractor-dotnet

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Other
922 stars 164 forks source link

Incorrectly identifies avif image file as "video/quicktime" #347

Closed rjgotten closed 6 months ago

rjgotten commented 9 months ago

The library incorrectly identifies AVIF image files as AV1 videos with MIME content type "video/quicktime" rather than the correct "image/avif".

Additionally the content type "video/quicktime" is incorrect. The standardized content type for AV1 video is "video/AV1": https://www.iana.org/assignments/media-types/video/AV1

The definition of that media type is strictly speaking limited to video-streaming via RTP and is not defined for other uses, but it makes more sense than "video/quicktime" which is just an opaque box of 'anything Apple Quicktime can play back.'

It's akin to speccing MP4 videos as "video/-x-msvideo," because Windows Media Player can play it back.

StefanOltmann commented 6 months ago

It's not really incorrect.

AVIF is like HEIC a flavor of HEIF, which is a ISO Base Media File Format (BMFF). This originated from QuickTime. So in fact it's a QuickTime file somehow. ;)

The fix is just to use the already implemented HEIC logic for AVIF files.

I just did that for the Java version: https://github.com/drewnoakes/metadata-extractor/pull/649

StefanOltmann commented 6 months ago

Resolved by #396 now. :)