search

drewnoakes / metadata-extractor-dotnet

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Other
922 stars 164 forks source link

Fix NikonPictureControl1Directory parsing #349

Closed drewnoakes closed 9 months ago

drewnoakes commented 9 months ago

Fix NikonPictureControl1Directory string reading. These fixed-width, null-terminated strings. We don't want those nulls in the string we return.

Also some minor tidying and adding a unit test.

gtiwari333 commented 8 months ago

@drewnoakes i am not sure how .NET works. but the code looks identical in Java and .NET.

Based on what i understand, this change will not read the value correctly. It will ONLY work if there are no null-terminated string in metadata.

        directory.Set(TagPictureControlVersion, reader.GetNullTerminatedStringValue(4));
        directory.Set(TagPictureControlName, reader.GetNullTerminatedStringValue(20));
        directory.Set(TagPictureControlBase, reader.GetNullTerminatedStringValue(20));

The issue is similar to what i described on https://github.com/drewnoakes/metadata-extractor/pull/636#issuecomment-1822998203.

In order to fix it, we need to either check the length of returned string and move the cursor after each read. Or, use a code similar to getNullTerminatedStringAndSkipToNextPosition.

drewnoakes commented 8 months ago

You're right, thanks. Fixed in https://github.com/drewnoakes/metadata-extractor-dotnet/pull/350 specifically e7cbf06e88efb7f6fca9dd83dd1214d23aef2329 and bff31ad2a582d6bd83a84c2f960ce30234f8cdad. I'll review the Java version, run the regression tests and get a fix up and another release out.