search

drewnoakes / metadata-extractor-dotnet

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Other
915 stars 158 forks source link

Spanify indexed reader classes #380

Closed drewnoakes closed 5 months ago

drewnoakes commented 5 months ago

Allows avoidance of temporary byte arrays, reduces the number of virtual calls to GetByteInternal, and uses conversion methods optimised by the framework (e.g. BinaryPrimitives).

drewnoakes commented 5 months ago

@iamcarbon please take a look if you have a chance.

iamcarbon commented 5 months ago

Looks great. Just one comment about a future simplification. Also, really great to see the API surface simplified with Spans.

drewnoakes commented 5 months ago

I'll investigate the encoding changes in a separate PR.

drewnoakes commented 5 months ago

@iamcarbon let's get 2.9.0 out soon. If there are any more public API changes you think we'd want, specifically related to performance in response to targeting newer frameworks, let me know.

I'm thinking of getting a prerelease package out today. We can also test the new infra for publishing to NuGet by creating releases here on GitHub.

drewnoakes commented 5 months ago

Pre-release package is available, per https://github.com/drewnoakes/metadata-extractor-dotnet/pull/389#issuecomment-1913993882