Spanify various methods

[iamcarbon]

@drewnoakes Ready for review.

[drewnoakes]

I'm seeing a few regressions in the image suite. One I called out above (stack overflow on negative size), and another seems to be in ICC data, as quite a few files now give:

DOTNET [ERROR: ICC Profile] Exception reading ICC profile: Attempt to read from beyond end of underlying data source (requested index: 0, requested count: 4, max index: -1)

Let me know if you need a hand getting the regression suite set up on your machine. If you're not touching the Java version, you only need to set up the .NET runner (and can comment out the call to run the Java lib too).

[iamcarbon]

Getting that setup now.

[drewnoakes]

@iamcarbon let me know if you'd like me to pick this up. No real rush, but I'd like to get 2.9 out in the next couple of weeks.

[markegorman]

I don’t know what this is or why I’m getting it

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Drew Noakes @.> Sent: Sunday, February 18, 2024 4:36:50 AM To: drewnoakes/metadata-extractor-dotnet @.> Cc: Subscribed @.***> Subject: Re: [drewnoakes/metadata-extractor-dotnet] Spanify various methods (PR #406)

@iamcarbonhttps://github.com/iamcarbon let me know if you'd like me to pick this up. No real rush, but I'd like to get 2.9 out in the next couple of weeks.

— Reply to this email directly, view it on GitHubhttps://github.com/drewnoakes/metadata-extractor-dotnet/pull/406#issuecomment-1951205796, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKVH5CC32ZYYGNHYSKOJ5O3YUHRVFAVCNFSM6AAAAABC4UOBCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGIYDKNZZGY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

[drewnoakes]

@markegorman you're watching this repo and must have configured GitHub to send you emails. https://github.com/drewnoakes/metadata-extractor-dotnet/watchers

[iamcarbon]

@drewnoakes OK, I got the regression suite working. Couple regressions I still need to figure out.

I'm going to break this PR apart few simpler PRs, and may back out of on the ICC span changes since this changes some error messages. I'll get that done this week.

[drewnoakes]

Sounds good. I suggest also running the suite without your changes, just to baseline. It's possible that different environmental factors create a diff. I try to minimise that, but it's hard.

[iamcarbon]

Closing this in favor of smaller incremental PRs.