search

drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.56k stars 480 forks source link

Review QuickTime matrix calculation #384

Closed drewnoakes closed 4 years ago

drewnoakes commented 5 years ago

QuickTime files use a 3x3 matrix to specify rotation/scaling/translation.

The .NET library received a port from the Java implementation, which was then fixed in https://github.com/drewnoakes/metadata-extractor-dotnet/pull/152.

We need the same change applied here.

payton commented 5 years ago

This data comes from the Track Header Atom (tkhd), which is not currently parsed in QuickTime files.

The same calculations are made in the MP4 implementation, though https://github.com/drewnoakes/metadata-extractor/blob/5124606e5d3d1fa7183fb8435cf490448ef79279/Source/com/drew/metadata/mp4/boxes/TrackHeaderBox.java#L76-L82

gmanjon commented 4 years ago

Hi Everyone! Great tool. Really awsome.

If I'm not mistaken this issue has been fixed in this commit:

https://github.com/drewnoakes/metadata-extractor/commit/40fd789c3076af09e1d22ccd7f6192d854850574

I was going to develop it because I needed this info but I found it on master. When are new versions released? Thank you

drewnoakes commented 4 years ago

@gmanjon thanks for following up, I'll close this issue.

We've had a few changes recently. I'll get a new release out shortly.